[jboss-jira] [JBoss JIRA] (JGRP-1766) NAKACK2/UNICAST3: faster acceptance test

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934385#comment-12934385 ] 

Bela Ban commented on JGRP-1766:
--------------------------------

I need to retract the previous comment: message batches received by NAKACK2 have the same dest: so either all messages in a batch have dest=null or all messages have dest!= null ! So the first comment is still valid and this optimization can be also be done for NAKACK2 !
                
> NAKACK2/UNICAST3: faster acceptance test
> ----------------------------------------
>
>                 Key: JGRP-1766
>                 URL: https://issues.jboss.org/browse/JGRP-1766
>             Project: JGroups
>          Issue Type: Enhancement
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>             Fix For: 3.5
>
>
> In NAKACK2/UNICAST3, when a message batch is received, we check every single message for presence of the corresponding header. If present we accept (and later process) the message.
> A faster acceptance test would be to check if the destination of the message batch matches, e.g.
> * UNICAST3: {{MessageBatch.getDest() != null}}
> * NAKACK2: {{MessageBatch.getDest() == nul}}
> If these conditions are false, we simply pass the batch up. This is faster than iterating through every message in the batch.
> Same for single messages: this is already done in UNICAST3, but not in NAKACK2.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira