[jboss-jira] [JBoss JIRA] (JGRP-1773) TP$MyHandler.handleSingleMessage() makes an unnecessary copy of the buffer

Bela Ban (JIRA) issues at jboss.org
Fri Jan 17 06:59:32 EST 2014


Bela Ban created JGRP-1773:
------------------------------

             Summary: TP$MyHandler.handleSingleMessage() makes an unnecessary copy of the buffer
                 Key: JGRP-1773
                 URL: https://issues.jboss.org/browse/JGRP-1773
             Project: JGroups
          Issue Type: Enhancement
            Reporter: Bela Ban
            Assignee: Bela Ban
             Fix For: 3.5


When a single message is received, we pass it to the thread pool for parsing, passing a copy of the byte array to the MyHandler runnable.
The parsing then creates a new Message and calls readFrom(). This method reads the headers and then creates a payload buffer of the size read from the input stream, then copies {{size}} bytes from the input stream to the mesage's payload.
This is an unneeded copy; as we already have a copy of the byte array, we only need to *reference* the byte array from the message and set the offset and length, saving us one copy of the buffer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jboss-jira mailing list