[jboss-jira] [JBoss JIRA] (SECURITY-786) Improve Memory Performance when Audit Logging is Off

[Philippe Marschall (JIRA)]

Philippe Marschall created SECURITY-786:
-------------------------------------------

             Summary: Improve Memory Performance when Audit Logging is Off
                 Key: SECURITY-786
                 URL: https://issues.jboss.org/browse/SECURITY-786
             Project: PicketBox 
          Issue Type: Patch
      Security Level: Public (Everyone can see)
          Components: JBossSX
            Reporter: Philippe Marschall
            Assignee: Stefan Guilhen


We did some profiling of or JBoss AS instance and noticed that audit logging on JavaEE resources is causing most of our allocations outside [TLAB|http://openjdk.java.net/groups/hotspot/docs/HotSpotGlossary.html#TLAB]s. This was a bit surprising to use since we don't have audit logging on. We tracked them down to {{org.jboss.security.javaee.AbstractJavaEEHelper.authorizationAudit(String, Resource, Exception)}} which unnecessarily does an eager string conversion of every {{org.jboss.security.authorization.Resource}}. This could be done lazily on demand when audit logging is on in {{AuditEvent#toString}}. Since the map is already of type {{Map<String,Object>}} simply removing the call to {{#toString()}} fixes this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira