[jboss-jira] [JBoss JIRA] (WFLY-1415) Move away from expensive enum switch

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981409#comment-12981409 ] 

David Lloyd commented on WFLY-1415:
-----------------------------------

The most important thing to look at are the XML parsers.  They use enums for element and attribute names; instead we can just switch and match on the literal string.

As for JIRA formatting, click on the circled ? symbol for information on the tags and formatting.  It's not HTML.

> Move away from expensive enum switch
> ------------------------------------
>
>                 Key: WFLY-1415
>                 URL: https://issues.jboss.org/browse/WFLY-1415
>             Project: WildFly
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>            Reporter: David Lloyd
>            Priority: Minor
>              Labels: janitor
>             Fix For: 9.0.0.CR1
>
>
> We use enums and enum switch extensively.  These constructs generate many, many additional classes and bloat the code base unnecessarily.
> All cases where we are using enum-based switches for our XML parsers should be converted to use Java 7 String switch instead.  The enum values shall be replaced with String constant fields, all enum switches converted to String switches, and all enum types removed from these classes.  The net result should be a reduction by dozens if not hundreds of .class files, and possibly a measurable performance boost as well.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)