[jboss-jira] [JBoss JIRA] (WFLY-3565) Incorrect use of ReloadRequiredWriteAttributeHandler for host resources

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983496#comment-12983496 ] 

Brian Stansberry commented on WFLY-3565:
----------------------------------------

What needs to happen here first is an analysis of the resources in the tree starting at /host=* but ignoring /host=*/server=* to look for cases where

1) the :add handler for the resource updates the runtime at boot. Ignore cases where the resource is just storing data for use on a server it creates, without making use of it in the HC's own runtime
2) One or more attributes use ReloadRequiredWriteAttributeHandler
3) but they don't override requiresRuntime to use an appropriate check.

I don't see any reason why the OperationContext interface needs to be changed.

The resources not under /host=* are not relevant as they only update the model. Stuff under /core-service=management may be an exception but that can be examined later.

Once that first part is done we can look into other similar cases.

> Incorrect use of ReloadRequiredWriteAttributeHandler for host resources
> -----------------------------------------------------------------------
>
>                 Key: WFLY-3565
>                 URL: https://issues.jboss.org/browse/WFLY-3565
>             Project: WildFly
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Domain Management
>    Affects Versions: 8.1.0.Final
>            Reporter: Brian Stansberry
>            Assignee: Chao Wang
>            Priority: Critical
>             Fix For: 8.2.0.CR1, 9.0.0.Alpha1
>
>
> ReloadRequiredWriteAttributeHandler inherits the default behavior of AbstractWriteAttributeHandler.requiresRuntime(), which is to only process Stage.RUNTIME if context.isNormalServer(). So any use in host resources needs to override that behavior. This isn't done in at least some places. See https://bugzilla.redhat.com/show_bug.cgi?id=1085228 for an example.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)