[jboss-jira] [JBoss JIRA] (JGRP-1765) TP: enable loopback by default and discard own multicasts

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12951571#comment-12951571 ] 

Bela Ban edited comment on JGRP-1765 at 7/10/14 10:45 AM:
----------------------------------------------------------

Actually, we *can* use the sender's physical address: in UDP, we're now sending multicasts via the DatagramSocket and *not* the MulticastSocket (only used for receiving mcasts). This allows us to get the sender's address and (real, not mcast) port and thus we can discard messages from ourself.
The disadvantage of using {{UDP.sock}} rather than {{UDP.mcast_sock}} for sending of multicast messages is that the routing on MacOS (the only one found so far) cannot handle this, causing [1].

[1] https://issues.jboss.org/browse/JGRP-1765


was (Author: belaban):
Actually, we *can* use the sender's physical address: in UDP, we're now sending multicasts via the DatagramSocket and *not* the MulticastSocket (only used for receiving mcasts). This allows us to get the sender's address and (real, not mcast) port and thus we can discard messages from ourself.

> TP: enable loopback by default and discard own multicasts
> ---------------------------------------------------------
>
>                 Key: JGRP-1765
>                 URL: https://issues.jboss.org/browse/JGRP-1765
>             Project: JGroups
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>             Fix For: 3.5
>
>
> Enable {{TP.looback}} by default (deprecate and ignore prop): all messages sent by self are passed right to a thread pool to send them up again.
> When a multicast message sent by self is received, it is currently passed to a thread pool, de-serialized and only then discarded if loopback=true. This means that we create an unneeded buffer for de-serializationand perform de-serialization.
> SOLUTION: discard the multicast from self immediately when receiving it, in {{TP.receive()}}



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)