[jboss-jira] [JBoss JIRA] (REMJMX-78) Make XNIO and Remoting options be configurable

[Carlo Bonamico (JIRA)]

    [ https://issues.jboss.org/browse/REMJMX-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987632#comment-12987632 ] 

Carlo Bonamico commented on REMJMX-78:
--------------------------------------

As a minimum, it would be necessary to allow for external configuration of the SSL options. If the server has a NON-SSL jmx connector, the client would not connect to it. 
The issue is with the class org.jboss.remoting3.jmx.RemotingConnector which initializes XNIO with a fixed, built-in OptionsMap, which cannot be overriden with properties from the environment map. 
Only the authentication credentials are passed on...

        // open a connection
        final IoFuture<Connection> futureConnection = endpoint.connect(convert(serviceUrl), getOptionMap(), handler);

And this is currently the fixed map

private OptionMap getOptionMap() {
        OptionMap.Builder builder = OptionMap.builder();
        builder.set(SASL_POLICY_NOANONYMOUS, Boolean.FALSE);
        builder.set(SASL_POLICY_NOPLAINTEXT, Boolean.FALSE);

        List<Property> tempProperties = new ArrayList<Property>(1);
        tempProperties.add(Property.of("jboss.sasl.local-user.quiet-auth", "true"));
        builder.set(Options.SASL_PROPERTIES, Sequence.of(tempProperties));

        builder.set(Options.SSL_ENABLED, true);
        builder.set(Options.SSL_STARTTLS, true);

        return builder.getMap();
    }

> Make XNIO and Remoting options be configurable
> ----------------------------------------------
>
>                 Key: REMJMX-78
>                 URL: https://issues.jboss.org/browse/REMJMX-78
>             Project: Remoting JMX
>          Issue Type: Feature Request
>    Affects Versions: 1.1.0.Final
>         Environment: EAP 6.1.1
>            Reporter: Osamu Nagano
>            Assignee: Darran Lofthouse
>
> Properties passed via "env" in "JMXConnectorFactory.connect(serviceURL, env)" is very limited.  And it is not passed to XNIO and Remoting like in line 192 below.  It is more flexible if those are configurable like in jboss-ejb-client project.
> https://github.com/jbossas/remoting-jmx/blob/1.1.0.Final/src/main/java/org/jboss/remotingjmx/RemotingConnector.java#L185
> {code}
>     191         final Xnio xnio = Xnio.getInstance();
>     192         endpoint = Remoting.createEndpoint("endpoint", xnio, OptionMap.create(Options.THREAD_DAEMON, true));
>     193         endpoint.addConnectionProvider(CONNECTION_PROVIDER_URI, new RemoteConnectionProviderFactory(), OptionMap.EMPTY);
> {code}



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)