[jboss-jira] [JBoss JIRA] (JBWEB-290) Optimize string literals inside jsp expressions

[John O'Hara (JIRA)]

    [ https://issues.jboss.org/browse/JBWEB-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12949174#comment-12949174 ] 

John O'Hara commented on JBWEB-290:
-----------------------------------

Thinking about this in more generalized terms, it occurs when the string concat operator + is used within expressions.  When parsing the jsp page, if we can remove string literals from inside expressions and treat them as standard TemplateText nodes in the parser, we can eliminate string concatenation within expressions and corresponding pressure placed on the heap by StringBuilder
                
> Optimize string literals inside jsp expressions 
> ------------------------------------------------
>
>                 Key: JBWEB-290
>                 URL: https://issues.jboss.org/browse/JBWEB-290
>             Project: JBoss Web
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Tomcat
>    Affects Versions: JBossWeb-3.0.0.Final
>            Reporter: John O'Hara
>            Assignee: Remy Maucherat
>
> After setting genStringAsCharArray=true, we continue to see StringBuilder concatenating string literals for each jsp request for some of our jsp pages; instead of creating a static char[].
> This occurs when a string literal is included in a jsp expression, e.g.;
> <%="<INPUT type=\"hidden\" name=\"name\" value=\"" + obj.getName() + "\">"%>
> Is it possible to identify string literals inside expressions during the tokenization phase of parsing jsp pages in apache jasper and treat them as text nodes so that the apache jasper generator can apply the same optimizations as string literals outside the jsp expression?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira