[jboss-jira] [JBoss JIRA] (DROOLS-491) drools-karaf-features should avoid declaring its own dependency versions

[Geoffrey De Smet (JIRA)]

    [ https://issues.jboss.org/browse/DROOLS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969722#comment-12969722 ] 

Geoffrey De Smet commented on DROOLS-491:
-----------------------------------------

Here's a list of all the version properties that are available in every KIE pom (including this one):
https://github.com/jboss-integration/jboss-integration-platform-bom/blob/master/pom.xml#L102

> drools-karaf-features should avoid declaring its own dependency versions
> ------------------------------------------------------------------------
>
>                 Key: DROOLS-491
>                 URL: https://issues.jboss.org/browse/DROOLS-491
>             Project: Drools
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 6.1.0.Beta3
>            Reporter: Geoffrey De Smet
>            Assignee: Michael Biarnes Kiefer
>
> At the top of this file:
> https://github.com/droolsjbpm/droolsjbpm-integration/blob/master/drools-osgi/drools-karaf-features/pom.xml
> We find:
> {code}
> <!-- Normal reuses -->
>     <!-- TODO Because these properties moved into the jboss-integration-platform-bom, we can't use them directly: -->
>     <!--<karaf.version.org.apache.camel>${version.org.apache.camel}</karaf.version.org.apache.camel>-->
>     <!--<karaf.version.org.apache.cxf>${version.org.apache.cxf}</karaf.version.org.apache.cxf>-->
>     <!--<karaf.version.org.apache.helix>${version.org.apache.helix}</karaf.version.org.apache.helix>-->
>     <!--<karaf.version.com.google.protobuf>${version.com.google.protobuf}</karaf.version.com.google.protobuf>-->
>     <!--<karaf.version.joda-time>${version.joda-time}</karaf.version.joda-time>-->
>     <!--<karaf.version.org.jboss.solder>${version.org.jboss.solder}</karaf.version.org.jboss.solder>-->
>     <!--<karaf.version.org.jboss.seam>${version.org.jboss.seam}</karaf.version.org.jboss.seam>-->
>     <!--<karaf.version.org.jboss.weld>${version.org.jboss.weld}</karaf.version.org.jboss.weld>-->
>     <!--<karaf.version.org.mvel>${version.org.mvel}</karaf.version.org.mvel>-->
>     <!-- TODO Instead of hard coding them and using maven filtering, we should use the karaf features-maven-plugin -->
>     <karaf.version.org.apache.camel>2.10.3</karaf.version.org.apache.camel>
>     <karaf.version.org.apache.cxf>2.6.6</karaf.version.org.apache.cxf>
>     <karaf.version.org.apache.helix>0.6.1-incubating</karaf.version.org.apache.helix>
>     <karaf.version.com.google.protobuf>2.5.0</karaf.version.com.google.protobuf>
>     <karaf.version.joda-time>1.6.2</karaf.version.joda-time>
>     <karaf.version.org.jboss.solder>3.2.0.Final</karaf.version.org.jboss.solder>
>     <karaf.version.org.jboss.seam>3.1.0.Final</karaf.version.org.jboss.seam>
>     <karaf.version.org.jboss.weld>1.1.13.Final</karaf.version.org.jboss.weld>
>     <karaf.version.org.mvel>2.1.6.Final</karaf.version.org.mvel>
> {code}
> That TODO "TODO Because these properties moved into the jboss-integration-platform-bom, we can't use them directly" is *no longer valid*. We now have the jboss-integration-platform-parent as a parent, so we do have those versions available, so there's no need to hardcode those versions.
> As for the other versions
> {code}
>     <!-- Overwrites with a different Maven version -->
>     <karaf.version.commons-codec>1.7</karaf.version.commons-codec>
>     <karaf.version.javax.enterprise.cdi>1.0-SP4</karaf.version.javax.enterprise.cdi>
>     <karaf.version.javax.inject>1.0</karaf.version.javax.inject>
>     <karaf.version.org.codehaus.janino>2.6.1</karaf.version.org.codehaus.janino>
>     <karaf.version.org.eclipse.jdt.core.compiler>4.2.1</karaf.version.org.eclipse.jdt.core.compiler>
>     <!-- Overwrites with a servicemix version -->
>     <karaf.servicemix.version.com.google.protobuf>2.4.1_1</karaf.servicemix.version.com.google.protobuf>
>     <karaf.servicemix.version.com.sun.xml.bind.jaxb>2.2.1.1_2</karaf.servicemix.version.com.sun.xml.bind.jaxb>
>     <karaf.servicemix.version.com.thoughtworks.xstream>1.4.3_1</karaf.servicemix.version.com.thoughtworks.xstream>
>     <karaf.servicemix.version.javax.xml.bind.jaxb>1.9.0</karaf.servicemix.version.javax.xml.bind.jaxb>
>     <karaf.servicemix.version.org.antlr>3.5_1</karaf.servicemix.version.org.antlr>
>     <karaf.servicemix.version.org.apache.poi>3.9_2</karaf.servicemix.version.org.apache.poi>
>     <karaf.servicemix.version.org.codehaus.woodstox>3.2.9_3</karaf.servicemix.version.org.codehaus.woodstox>
>     <karaf.servicemix.version.org.quartz-scheduler>2.1.6_1</karaf.servicemix.version.org.quartz-scheduler>
>     <!-- Specs -->
>     <karaf.servicemix.version.scripting-api>2.4.0</karaf.servicemix.version.scripting-api>
>     <!-- Special overwrites -->
>     <karaf.version.org.apache.aries.jpa>1.0.1</karaf.version.org.apache.aries.jpa>
> {code}
> figure out if any of those can be removed from being hard coded...



--
This message was sent by Atlassian JIRA
(v6.2.3#6260)