[jboss-jira] [JBoss JIRA] (WFLY-2982) refactor two phase persistence unit services (PhaseOnePersistenceUnitServiceImpl + PersistenceUnitServiceImpl) into one service

[Scott Marlow (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972108#comment-12972108 ] 

Scott Marlow commented on WFLY-2982:
------------------------------------

Some of the competing concerns for this task:
* The DataSource may be needed before any application classloaders have been used.  The DataSource is currently used when Hibernate is called to create the entity manager factory.  For the two phase bootstrap approach, Hibernate accesses the DataSource during the first bootstrap phase.  Currently, we do not have a way to prevent application classloaders from being used before the WildFly Install deployment phase.  Persistence providers are allowed to rewrite entity classes as per the JPA specification (which has been part of EE since EE 5).
* The CDI bean manager passed to the persistence provider (for entity listeners) cannot be used until the WildFly Install deployment phase.
* Entity class rewriting needs to be supported as per the JPA spec (see the above).

> refactor two phase persistence unit services (PhaseOnePersistenceUnitServiceImpl + PersistenceUnitServiceImpl) into one service
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-2982
>                 URL: https://issues.jboss.org/browse/WFLY-2982
>             Project: WildFly
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: JPA / Hibernate
>    Affects Versions: 8.0.0.Final
>            Reporter: Scott Marlow
>            Assignee: Scott Marlow
>             Fix For: 9.0.0.CR1
>
>
> Related feedback from https://github.com/wildfly/wildfly/pull/4722:
> {quote}
> This is asymetrical, so if this service , and phase one are stopped, and then phase 1 is started again, phase 2 will appear started. The side effects seem minor though
> {quote}
> {quote}
> We have a long term goal to somehow verify every service can be stopped and started with the expected effect. Right now many of our services are not restartable which makes potential new features like partial deployment standby hard to achieve. So Im just offering pointers whenever I see lifecycle symmetry issues.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2.3#6260)