[jboss-jira] [JBoss JIRA] (WFCORE-266) Deprecate the ParameterValidator constructor variants that accept allowNull and allowExpressions params

Brian Stansberry (JIRA) issues at jboss.org
Wed Nov 19 14:04:39 EST 2014


Brian Stansberry created WFCORE-266:
---------------------------------------

             Summary: Deprecate the ParameterValidator constructor variants that accept allowNull and allowExpressions params
                 Key: WFCORE-266
                 URL: https://issues.jboss.org/browse/WFCORE-266
             Project: WildFly Core
          Issue Type: Task
          Components: Domain Management
            Reporter: Brian Stansberry
             Fix For: 1.0.0.CR1


Most of the ParameterValidator implementations that get passed to AttributeDefinition accept params to control whether null and expressions are allowed. These are now redundant, as AttributeDefinition wraps the provided validator with NillableOrExpressionParameterValidator, and it handles that aspect of validation based on the settings of the AD.

So we should deprecate these constructor variants to let people know they aren't needed. Ideally shift the code as well.

CRITICAL: before doing this, make sure the AttributeDefinition variants that support complex types properly wrap any validators that are configured for *element* validation. A quick look shows that ListAttributeDefinition.Builder and MapAttributeDefinition.Builder do.



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)


More information about the jboss-jira mailing list