[jboss-jira] [JBoss JIRA] (ELY-43) Clean up Base64

[Darran Lofthouse (JIRA)]

    [ https://issues.jboss.org/browse/ELY-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008419#comment-13008419 ] 

Darran Lofthouse commented on ELY-43:
-------------------------------------

FYI I believe Undertow already contains a forked implementation of this class - if we were able to adopt it within Elytron it does mean when we add a dependency on Elytron from Undertow we can remove one further Base64 fork.

> Clean up Base64
> ---------------
>
>                 Key: ELY-43
>                 URL: https://issues.jboss.org/browse/ELY-43
>             Project: WildFly Elytron
>          Issue Type: Feature Request
>          Components: Utils
>            Reporter: Darran Lofthouse
>            Assignee: Farah Juma
>             Fix For: 1.0.0.Beta1
>
>
> The Base64 implementation has been split out of PasswordUtils some additional steps are needed to finish cleaning it up: -
>  - Look at switching to input and output streams instead of the custom iterators it is using.
>  - Consider the ByteStringBuilder from SASL
>  - As potentially more visible ensure clearer method names.
>  - Ensure adequate javadoc and cross referencing of standards supported.
>    e.g. If we implement an RFC ensure the number is referenced.
>  - Testing of each variant
>    - Consider optional support, e.g. decoding a padded String
>    - Go beyond testing we can decode what we encode and ensure pre-encoded values can be handled adequately.
> Any other clean up here that seems relevant.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)