[jboss-jira] [JBoss JIRA] (SECURITY-786) Improve Memory Performance when Audit Logging is Off

[Philippe Marschall (JIRA)]

     [ https://issues.jboss.org/browse/SECURITY-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philippe Marschall resolved SECURITY-786.
-----------------------------------------
    Fix Version/s: PicketBox_4_9_0.Beta1
       Resolution: Done


pull request merged

> Improve Memory Performance when Audit Logging is Off
> ----------------------------------------------------
>
>                 Key: SECURITY-786
>                 URL: https://issues.jboss.org/browse/SECURITY-786
>             Project: PicketBox 
>          Issue Type: Patch
>          Components: JBossSX
>            Reporter: Philippe Marschall
>            Assignee: Stefan Guilhen
>             Fix For: PicketBox_4_9_0.Beta1
>
>
> We did some profiling of or JBoss AS instance and noticed that audit logging on JavaEE resources is causing most of our allocations outside [TLAB|http://openjdk.java.net/groups/hotspot/docs/HotSpotGlossary.html#TLAB]s. This was a bit surprising to use since we don't have audit logging on. We tracked them down to {{org.jboss.security.javaee.AbstractJavaEEHelper.authorizationAudit(String, Resource, Exception)}} which unnecessarily does an eager string conversion of every {{org.jboss.security.authorization.Resource}}. This could be done lazily on demand when audit logging is on in {{AuditEvent#toString}}. Since the map is already of type {{Map<String,Object>}} simply removing the call to {{#toString()}} fixes this.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)