[jboss-jira] [JBoss JIRA] (WFLY-3955) Non-persistent overlay gets persisted later

[Stan Silvert (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010036#comment-13010036 ] 

Stan Silvert commented on WFLY-3955:
------------------------------------

Would you be opposed to supporting it for overlays?   

Otherwise it is very difficult to add overlays dynamically.   I need to deploy a WAR and add whatever overlays are available on the file system at startup.

Without persistent=false I would have to determine what has been persisted and then remove each part individually before building it up again.  I'm not even sure if that can be done at startup?

Alternatively, we could provide an operation that removes the persisted overlay from the top level.  
/deployment-overlay=myoverlay:remove

This operation can not be done currently unless "myoverlay" is empty.  But it would be safe to do on a fully-defined overlay during startup.

> Non-persistent overlay gets persisted later
> -------------------------------------------
>
>                 Key: WFLY-3955
>                 URL: https://issues.jboss.org/browse/WFLY-3955
>             Project: WildFly
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 8.1.0.Final, 9.0.0.Alpha1
>            Reporter: Stan Silvert
>            Assignee: Stuart Douglas
>
> In an add handler at startup, I have code that creates a non-persistent overlay like this:
> {code}
> private void addOverlay(OperationContext context) throws OperationFailedException {
>         PathAddress overlayAddress = PathAddress.pathAddress(PathElement.pathElement(DEPLOYMENT_OVERLAY, overlayName));
>         ModelNode addOp = Util.createOperation(ADD, overlayAddress);
>         addOp.get(PERSISTENT).set(false);        
>         context.addStep(addOp, getAddHandler(context, overlayAddress), OperationContext.Stage.MODEL);
>     }
> private OperationStepHandler getAddHandler(OperationContext context, PathAddress address) {
>         ImmutableManagementResourceRegistration rootResourceRegistration = context.getRootResourceRegistration();
>         return rootResourceRegistration.getOperationHandler(address, ADD);
>     }
> {code}
> addOverlay() is called from the populateModel() method of my Add Handler.  This works fine and creates the overlay without persisting to standalone.xml.
> However, if I deploy any WAR then the overlay is written out to standalone.xml.
> I can get you some better test code if you need it later.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)