[jboss-jira] [JBoss JIRA] (WFLY-3855) Fix AuditLogFieldsOfLogTestCase

[Josef Cacek (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011929#comment-13011929 ] 

Josef Cacek edited comment on WFLY-3855 at 10/15/14 4:30 AM:
-------------------------------------------------------------

The problem is not in the Test, but in the auditlog code which uses "WildFly Full" value as an application name (APP-NAME header field). It's not allowed to use space in the value, because the space is a header field separator in SysLog messages. Look at Syslog message format - http://tools.ietf.org/html/rfc5424#section-6

Please revert the test-hack after the APP-NAME header field value is fixed (WFLY-3979).


was (Author: jcacek):
The problem is not in the Test, but in the auditlog code which uses "WildFly Full" value as an application name (APP-NAME header field). It's not allowed to use space in the value, because the space is a header field separator in SysLog messages. Look at Syslog message format - http://tools.ietf.org/html/rfc5424#section-6

Please revert the test-hack after the APP-NAME header field value is fixed.

> Fix AuditLogFieldsOfLogTestCase
> -------------------------------
>
>                 Key: WFLY-3855
>                 URL: https://issues.jboss.org/browse/WFLY-3855
>             Project: WildFly
>          Issue Type: Bug
>    Affects Versions: 9.0.0.Alpha1
>            Reporter: Tomaz Cerar
>            Assignee: Tomaz Cerar
>
> Test started to fail with:
> {noformat}
> java.lang.IllegalArgumentException: Invalid character: -
>     at org.jboss.dmr.JSONParserImpl.invalid(JSONParserImpl.java:136)
>     at org.jboss.dmr.JSONParser.yyLex(JSONParser.java:596)
>     at org.jboss.dmr.JSONParser.yyParse(JSONParser.java:662)
>     at org.jboss.dmr.ModelNode.fromJSONString(ModelNode.java:1390)
>     at org.jboss.as.test.manualmode.auditlog.AuditLogFieldsOfLogTestCase.testAuditLoggingFields(AuditLogFieldsOfLogTestCase.java:106)
> {noformat}
> message was (notice the extra "-"  in front)
> {noformat}
>  - {
>     "type" : "core",
>     "r/o" : false,
>     "booting" : false,
>     "version" : "9.0.0.Alpha1",
>     "user" : "IAmAdmin",
>     "domainUUID" : null,
>     "access" : "NATIVE",
>     "remote-address" : "127.0.0.1/127.0.0.1",
>     "success" : true,
>     "ops" : [{
>         "operation" : "write-attribute",
>         "address" : [
>             {
>                 "core-service" : "management"
>             },
>             {
>                 "access" : "audit"
>             },
>             {
>                 "logger" : "audit-log"
>             }
>         ],
>         "name" : "log-boot",
>         "value" : true,
>         "operation-headers" : {
>             "caller-type" : "user",
>             "access-mechanism" : "NATIVE"
>         }
>     }]
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)