[jboss-jira] [JBoss JIRA] (ELY-100) Digest-MD5 authorization check is incorrect

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/ELY-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012188#comment-13012188 ] 

David Lloyd commented on ELY-100:
---------------------------------

The IDEA inspection is called "'equals()' between objects of inconvertible types".  I'm sure Eclipse has a similar one.

> Digest-MD5 authorization check is incorrect
> -------------------------------------------
>
>                 Key: ELY-100
>                 URL: https://issues.jboss.org/browse/ELY-100
>             Project: WildFly Elytron
>          Issue Type: Bug
>          Components: SASL
>            Reporter: David Lloyd
>            Assignee: Peter Skopek
>
> In MD5DigestSaslServer.java line 232-233 we have this code:
> {code}
>         byte[] authzid = parsedDigestResponse.get("authzid");
>         String authorizationId = (authzid==null || authzid.equals(userName)) ? null : new String(authzid, Charsets.UTF_8);
> {code}
> The {{equals}} compare between {{authzid}} (a byte array) and {{userName}} (a String) is invalid.  However if I fix it in the obvious manner, tests fail.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)