[jboss-jira] [JBoss JIRA] (JGRP-1893) ENCRYPT: Thread safety issues during key changes

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013334#comment-13013334 ] 

Bela Ban commented on JGRP-1893:
--------------------------------

OK, thanks.
Does the issue exist in master at all ? Because if it does, it would be great to have the fix in upstream, too. Otherwise it'll be only in 3.4. Note that there's also a 3.5 branch, which is probably very similar to master.

> ENCRYPT: Thread safety issues during key changes
> ------------------------------------------------
>
>                 Key: JGRP-1893
>                 URL: https://issues.jboss.org/browse/JGRP-1893
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Tero Leppikangas
>            Assignee: Bela Ban
>
> For symmetric encryption, ENCRYPT has members with shared state: secret key, version and ciphers. In order for to provide consistent state between different threads accessing these members, they should be synchronized.
> I have implemented one solution by wrapping the state in separate object which can be found here:
> https://github.com/tepitebson/JGroups/tree/ENCRYPT_Thread_safety
> I also have replaced the WeakHashMap holding the previous keys with Cache in google's guava library so my solution probably is not suitable for an official solution.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)