[jboss-jira] [JBoss JIRA] (JGRP-1893) ENCRYPT: Thread safety issues during key changes

[Tero Leppikangas (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015241#comment-13015241 ] 

Tero Leppikangas commented on JGRP-1893:
----------------------------------------

Hi.
Sorry for the previous comment, the fix for JGRP-1880 was not the real reason. The trace log just fills up with stacktraces from UDP since the setTimeToLive throws IOException with "not implemented" from all nodes in my test. The real reason was that all parts of my own code was not compatible with 3.5. I will do more testing and create pull requests when I feel that things are ok from my point of view.

> ENCRYPT: Thread safety issues during key changes
> ------------------------------------------------
>
>                 Key: JGRP-1893
>                 URL: https://issues.jboss.org/browse/JGRP-1893
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Tero Leppikangas
>            Assignee: Bela Ban
>
> For symmetric encryption, ENCRYPT has members with shared state: secret key, version and ciphers. In order for to provide consistent state between different threads accessing these members, they should be synchronized.
> I have implemented one solution by wrapping the state in separate object which can be found here:
> https://github.com/tepitebson/JGroups/tree/ENCRYPT_Thread_safety
> I also have replaced the WeakHashMap holding the previous keys with Cache in google's guava library so my solution probably is not suitable for an official solution.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)