[jboss-jira] [JBoss JIRA] (WFLY-4374) java.lang.IllegalAccessError and other classloader issues

[Anindhya Sharma (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056640#comment-13056640 ] 

Anindhya Sharma commented on WFLY-4374:
---------------------------------------

David,

We have supported multiple Java Application servers (and continue to do so) over the years and multiple versions of them. WebSphere, WebLogic and JBoss. In all the versions of all these products (JBoss included) we have never had this issue using the Class-Path entry in manifest file, even for the same class in different jar files. We have supported Jboss 4, 5, 6 and 7, the last one being 7.2.0.Final. Are you saying that the issue is due to how the implementation has been done in Jboss modules that is causing the issue and that the implementation in Wildfly honors the Java EE spec and hence you will not fix this? Trying to understand why this was changed in Wildfly when all other application servers in multiple versions honor this scheme? Is it because the Java EE spec changed or because that is how Jboss modules are implemented?

Given that all previous versions of Jboss have worked like mentioned in the issue (and other products still support it), would you be able to help point out specific of the Java EE specification that caused this changed in how Wildfly is working? Again trying to understand whether Wildfly just fixed an issue that was there in previous versions of Jboss and other vendor products...?

Thanks!

> java.lang.IllegalAccessError and other classloader issues
> ---------------------------------------------------------
>
>                 Key: WFLY-4374
>                 URL: https://issues.jboss.org/browse/WFLY-4374
>             Project: WildFly
>          Issue Type: Bug
>          Components: Class Loading
>    Affects Versions: 8.2.0.Final, 9.0.0.Beta2
>         Environment: Windows 7/Java 7 update 67
>            Reporter: John Sipher
>            Assignee: David Lloyd
>         Attachments: problem-demo.zip
>
>
> Update 4/1/2015: I have verified that 9.0.0.Beta2 fixes the IllegalAccessError and the war file in problem-demo.zip/hello-world6/target now duplicates the original problem. The order of the jar files in the classpath should be
> WEB-INF/lib/patch/patch2.jar
> WEB-INF/lib/patch/patch1.jar
> WEB-INF/lib/base/helloworld-sans-cdi.jar
> org.jboss.as.quickstarts.helloworld.HelloService exists in both patch2.jar and helloworld-sans-cdi.jar. The version from patch2.jar should be used because it is first in the classpath, but the classloader is picking up the original class from helloworld-sans-cdi.jar instead.
> Original problem description follows:
> We use manifest-only jar files in our WAR and EAR files to control the order that jar files are searched for classes. When we issue patches, we put the modified class(es) in a separate jar file, add that jar file to the affected EAR or WAR file, and update the classpath in our manifest-only jar file to put the new patch at the beginning of the class path so that it will be used in place of the original class (which is still in the original jar file).
>  
> For example, WEB-INF/lib will contain a single jar file named manifest.jar and sub-folders named 3rdparty, base, patch, and custom. The Class-Path entry in WEB-INF/lib/manifest.jar|META-INF/MANIFEST.MF looks like this:
> Class-Path: 3rdparty/manifest.jar patch/manifest.jar base/manifest.jar custom/manifest.jar
>  
> When we publish a patch, the patch jar file is added to WEB-INF/lib/patch and to the front of the classpath in WEB-INF/lib/patch/manifest.jar's MANIFEST.MF.
>  
> This worked fine for us for years with JBoss 4.2.3.GA, 5.1.0.GA, 7.1.2.Final, and 7.2.0.Final, but it's broken in WildFly 8.2.0.Final. 
> When I run it in debug I can see where the problem shows up in this section of org.jboss.modules.Module (lines 562 - 573).
>         final String path = pathOfClass(className);
>         final Map<String, List<LocalLoader>> paths = getPathsUnchecked();
>         final List<LocalLoader> loaders = paths.get(path);
>         if (loaders != null) {
>             Class<?> clazz;
>             for (LocalLoader loader : loaders) {
>                 clazz = loader.loadClassLocal(className, resolve);
>                 if (clazz != null) {
>                     return clazz;
>                 }
>             }
>         }
> The modules in the loaders list at line 565 are
>  * deployment.service.ear.lib/base/shared.jar:main
>  * deployment.service.ear.lib/base/deployment.jar:main
>  * deployment.service.ear.lib/patch/patch.jar:main
> The last one should actually be the first in the list. I haven't been able to track down the actual source of the error yet.
> I've been trying to create a simple example based on the helloworld quickstart to reproduce the problem, but I haven't been successful yet because of other classloader errors that I've run into. I decided to go ahead and open this issue and document the things I am able to reproduce. Those are:
> 1. CDI injection doesn't work when the annotated classes are in jar files under WEB-INF/lib instead of unpacked in WEB-INF/classes. 
> 2. WildFly doesn't process the javax.servlet.annotation.WebServlet annotation if the jar file containing the annotated class is in a sub-folder of WEB-INF/lib.
> 3. WildFly throws a java.lang.IllegalAccessError trying to load a "patched" class.
> The first problem exists in both 7.2.0.Final and 8.2.0.Final. The other two problems are new in 8.2.0.Final.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)