[jboss-jira] [JBoss JIRA] (JBJCA-1257) SemaphoreConcurrentLinkedQueueManagedConnectionPool

[Radim Vansa (JIRA)]

    [ https://issues.jboss.org/browse/JBJCA-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056997#comment-13056997 ] 

Radim Vansa commented on JBJCA-1257:
------------------------------------

I don't have the stack trace anymore - it is a bug in error handling, so after I've found the cause I've fixed it. However, swallowing the original exception because of NPE in error handling makes it harder to find the cause.

Looking on the links above - I apologize, I've linked wrong line, the NPE is thrown at
{code}
log.throwableWhileAttemptingGetNewGonnection(clw.getConnectionListener(), t);
{code}
at https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L398

because an exception is thrown at https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L375

I'll fix the bug description right away...

> SemaphoreConcurrentLinkedQueueManagedConnectionPool
> ---------------------------------------------------
>
>                 Key: JBJCA-1257
>                 URL: https://issues.jboss.org/browse/JBJCA-1257
>             Project: IronJacamar
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.31.Final
>            Reporter: Radim Vansa
>            Assignee: Jesper Pedersen
>            Priority: Minor
>             Fix For: 1.2.4.Final
>
>
> With SemaphoreConcurrentLinkedQueueManagedConnectionPool, if creating a new connection fails with exception, logging this 
> {code}
> log.throwableWhileTryingMatchManagedConnectionThenDestroyingConnection(clw.getConnectionListener(), t);
> {code}
> https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L338
> causes NPE since clw == null. This way, the NPE is eventually swallowed on https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L437 and only generic ResourceException (without much info) is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)