[jboss-jira] [JBoss JIRA] (WFLY-4500) CMResourceService#stop fails to clean up

[Philippe Marschall (JIRA)]

Philippe Marschall created WFLY-4500:
----------------------------------------

             Summary: CMResourceService#stop fails to clean up
                 Key: WFLY-4500
                 URL: https://issues.jboss.org/browse/WFLY-4500
             Project: WildFly
          Issue Type: Patch
          Components: Transactions
            Reporter: Philippe Marschall
            Assignee: Tom Jenkinson


CMResourceService#stop fails to clean up values that #start creates.

The issue is the line
{code}
jtaEnvironmentBean.getValue().getPerformImmediateCleanupOfCommitMarkableResourceBranchesMap().remove(immediateCleanup);
{code}
immediateCleanup is a {{Boolean}} and the return type of {{getPerformImmediateCleanupOfCommitMarkableResourceBranchesMap()}} is {{Map<String, Boolean>}}

So this line never does anything. The line should read
{code}
jtaEnvironmentBean.getValue().getPerformImmediateCleanupOfCommitMarkableResourceBranchesMap().remove(jndiName);
{code}
because if we look a the #start method above we see
{code}
Map<String, Boolean> performImmediateCleanupOfConnectableResourceBranchesMap = jtaEnvironmentBean.getValue().getPerformImmediateCleanupOfCommitMarkableResourceBranchesMap();  
performImmediateCleanupOfConnectableResourceBranchesMap.put(jndiName, immediateCleanup);
{code}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)