[jboss-jira] [JBoss JIRA] (WFLY-4500) CMResourceService#stop fails to clean up

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-4500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058346#comment-13058346 ] 

Tom Jenkinson commented on WFLY-4500:
-------------------------------------

Change looks good to me from the transaction managers perspective - thanks Philippe!!

> CMResourceService#stop fails to clean up
> ----------------------------------------
>
>                 Key: WFLY-4500
>                 URL: https://issues.jboss.org/browse/WFLY-4500
>             Project: WildFly
>          Issue Type: Patch
>          Components: Transactions
>            Reporter: Philippe Marschall
>            Assignee: Philippe Marschall
>
> CMResourceService#stop fails to clean up values that #start creates.
> The issue is the line
> {code}
> jtaEnvironmentBean.getValue().getPerformImmediateCleanupOfCommitMarkableResourceBranchesMap().remove(immediateCleanup);
> {code}
> immediateCleanup is a {{Boolean}} and the return type of {{getPerformImmediateCleanupOfCommitMarkableResourceBranchesMap()}} is {{Map<String, Boolean>}}
> So this line never does anything. The line should read
> {code}
> jtaEnvironmentBean.getValue().getPerformImmediateCleanupOfCommitMarkableResourceBranchesMap().remove(jndiName);
> {code}
> because if we look a the #start method above we see
> {code}
> Map<String, Boolean> performImmediateCleanupOfConnectableResourceBranchesMap = jtaEnvironmentBean.getValue().getPerformImmediateCleanupOfCommitMarkableResourceBranchesMap();  
> performImmediateCleanupOfConnectableResourceBranchesMap.put(jndiName, immediateCleanup);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)