[jboss-jira] [JBoss JIRA] (WFCORE-665) When host jvm name and server jvm name are same then the host jvm settings are ignored

[Jay Kumar SenSharma (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062695#comment-13062695 ] 

Jay Kumar SenSharma commented on WFCORE-665:
--------------------------------------------

Pull Request is sent for Verification: 
https://github.com/wildfly/wildfly-core/pull/646

- I think that if the Host JVM name and the Server JVM names (like "Test") are same then we should first merge then the "this.jvmElement" should be formed, Else the server-group setting just overrides the "Test" settings as the "Test" JVMs actual values are defined at the Host JVM level, Server is simply referring to the Host JVM settings.
{code}
this.jvmElement = new JvmElement(jvmName,
-                resolveNilableExpressions(hostVM, expressionResolver, false),
-                resolveNilableExpressions(groupVM, expressionResolver, false),
-                resolveNilableExpressions(serverVM, expressionResolver, false));
{code}

host-controller/src/main/java/org/jboss/as/host/controller/ManagedServerBootCmdFactory.java

> When host jvm name and server jvm name are same then the host jvm settings are ignored
> --------------------------------------------------------------------------------------
>
>                 Key: WFCORE-665
>                 URL: https://issues.jboss.org/browse/WFCORE-665
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 1.0.0.Beta5
>         Environment: All
>            Reporter: Jay Kumar SenSharma
>            Assignee: Brian Stansberry
>
> - If the "host.xml" has the following JVM name defined 
> {code}
>     <jvms>
>         <jvm name="default">
>             <heap size="200m" max-size="2000m"/>
>             <permgen size="256m" max-size="256m"/>
>             <jvm-options>
>                 <option value="-server"/>
>             </jvm-options>
>         </jvm>
>         <jvm name="Test">
>             <heap size="300m" max-size="2500m"/>
>             <permgen size="128m" max-size="128m"/>
>         </jvm>
>     </jvms>
> {code}
> - If the server refers to the above JVM name as following:
> {code}
>     <servers>
>         <server name="server-one" group="main-server-group" auto-start="true">
>         <jvm name="Test"/>
>         </server>
>     </servers>
> {code}
> - In above case when the server-one is booted that time  it takes the value from "server-group" (in this case main-server-group) defined in the domain.xml
> {code}
>     <server-groups>
>         <server-group name="main-server-group" profile="full">
>             <jvm name="default">
>                 <heap size="64m" max-size="512m"/>
>             </jvm>
> {code}
> So the JVM settings defined for JVM name "Test" is overridden by server-group values:
> {code}
> 30201 jboss-modules.jar -agentpath:/usr/lib64/libabrt-java-connector.so=abrt=on -D[Server:server-one] -XX:PermSize=128m -XX:MaxPermSize=128m -Xms64m -Xmx512m -Djava.awt.headless=true -Djava.net.preferIPv4Stack=true -Djboss.home.dir=/wildfly-9.0.0.CR1-SNAPSHOT -Djboss.modules.system.pkgs=org.jboss.byteman -Djboss.server.log.dir=/wildfly-9.0.0.CR1-SNAPSHOT/domain/servers/server-one/log -Djboss.server.temp.dir=/wildfly-9.0.0.CR1-SNAPSHOT/domain/servers/server-one/tmp -Djboss.server.data.dir=/wildfly-9.0.0.CR1-SNAPSHOT/domain/servers/server-one/data -Dlogging.configuration=file:/wildfly-9.0.0.CR1-SNAPSHOT/domain/servers/server-one/data/logging.properties
> {code}
> *NOTICE* the JVM runtime value is  -Xms64m -Xmx512m, where as it was supposed to be -Xms300m -Xmx2500m   as that is the "Test" jvm setting.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)