[jboss-jira] [JBoss JIRA] (DROOLS-599) kjar archertype

[Matteo Mortari (JIRA)]

    [ https://issues.jboss.org/browse/DROOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095636#comment-13095636 ] 

Matteo Mortari commented on DROOLS-599:
---------------------------------------

Hello, just a quick question, is it really required to keep the header-comment-license to the generated files of this archetype, please?

I've noticed for example [this in commit 7172a50|https://github.com/droolsjbpm/droolsjbpm-knowledge/commits/master/kie-archetypes/kie-drools-archetype/src/main/resources/archetype-resources/src/main/resources/rules.drl] by [~mbiarnes] the net result is that an user would generate artifact from maven and then erase the header-comment-license as the user starts to write own rules in the generated drl file, because the rules are the user's own. Similar analogy would apply to the other files generated by this artifact, as generated files are indeed meant to be modified to adapt to user's need, and the reason why I didn't put this header in the original PR.

I can understand it is not a big deal to manually erase this header in all generated files where required, but if somebody is creating a lot of self-contained rule packages on a daily basis, it has an impact trust me =)

Just open question, thank you, Ciao!

> kjar archertype
> ---------------
>
>                 Key: DROOLS-599
>                 URL: https://issues.jboss.org/browse/DROOLS-599
>             Project: Drools
>          Issue Type: Feature Request
>    Affects Versions: 6.1.0.Final
>            Reporter: Matteo Mortari
>            Assignee: Mario Fusco
>             Fix For: 6.2.0.CR1
>
>
> I'm opening this JIRA as I will later open PR related to https://groups.google.com/d/msg/drools-development/uO17-kC4mvc/aBRunEcZ_b4J
> The version of the archetype defaults for non-CEP, non-Eclipse plugin in pom. There are property which user can change default value to have CEP, and Eclipse plug-in.
> For reference,
> * Set-up the new project's pom:
> ** Change Java version to 1.6 or greater, by including the maven-compiler-plugin
> ** Add Drools dependencies
> ** Change JUnit dependencies to version 4
> ** Add kie-maven-plugin
> ** [option] Add plug-in org.eclipse.m2e/lifecycle-mapping settings, to avoid Eclipse ERROR at the pom.xml line defining the kie-maven-plugin
> ** Set packaging to 'kjar'
> * ( ALT + F5 in betweens )
> * Creation of an initial .drl file in src/main/resources
> * Creation of minimal kmodule.xml in src/main/resources/META-INF directory
> * Create a simple JUnit test for:
> ** Creation of KieBase [option ->] with STREAM option for CEP features
> ** Creation of KieSession [option ->] with pseudo-clock
> ** [option: Advance] / Insert / Fire template
> ** ... and other verification/output patterns
> * Include SLF4J and LOG4J binding for logging, including a log4j.properties file in src/test/resources



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)