[jboss-jira] [JBoss JIRA] (WFCORE-924) Factor out common code for management interface definitions.

[Darran Lofthouse (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102917#comment-13102917 ] 

Darran Lofthouse edited comment on WFCORE-924 at 8/27/15 4:26 PM:
------------------------------------------------------------------

The class 'org.jboss.as.domain.controller.LocalHostControllerInfo' has probably been overly abused - whilst some information may be required from this interface it has ended up becoming a general purpose container of information used to initialise a management interface.

The following are all really items that could be pulled out: -

{code}
    /**
     * Gets the name of the security realm to use for for native management requests.
     *
     * @return the logical interface name
     */
    String getNativeManagementSecurityRealm();

    /**
     * Gets the name of the security realm to use for for HTTP management requests.
     *
     * @return the logical interface name
     */
    String getHttpManagementSecurityRealm();

    Collection<String> getAllowedOrigins();
{code}

Essentially anything that is only used to start up the management interface but does not have another use elsewhere should be removed.


was (Author: dlofthouse):
The class 'org.jboss.as.domain.controller.LocalHostControllerInfo' has probably been overly abused - whilst some information may be required from this interface it has ended up becoming a general purpose container of information used to initialise a management interface.

The following are all really items that could be pulled out: -

{code}
    /**
     * Gets the name of the security realm to use for for native management requests.
     *
     * @return the logical interface name
     */
    String getNativeManagementSecurityRealm();

    /**
     * Gets the name of the security realm to use for for HTTP management requests.
     *
     * @return the logical interface name
     */
    String getHttpManagementSecurityRealm();

    /**
     * Gets the username to use when authenticating against the
     * remote domain controller.
     *
     * @return the user name.
     */
    String getRemoteDomainControllerUsername();

    Collection<String> getAllowedOrigins();
{code}

Essentially anything that is only used to start up the management interface but does not have another use elsewhere should be removed.

> Factor out common code for management interface definitions.
> ------------------------------------------------------------
>
>                 Key: WFCORE-924
>                 URL: https://issues.jboss.org/browse/WFCORE-924
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Domain Management
>            Reporter: Darran Lofthouse
>            Assignee: Darran Lofthouse
>              Labels: affects_elytron
>             Fix For: 3.0.0.Alpha1
>
>
> These interfaces started off very simple and initially their attributes were fairly distinct due to the running mode they operated in - however as more and more attributes are added there is more common code than unique code and this is tending to mean all changes are being made in duplicate - double that if a change also impacts on the native definition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)