[jboss-jira] [JBoss JIRA] (WFCORE-1198) CLI does not resolve multiple properties if one property is undefined

[Chao Wang (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138820#comment-13138820 ] 

Chao Wang commented on WFCORE-1198:
-----------------------------------

[CLIExpressionResolver.java#L181|https://github.com/wildfly/wildfly-core/blob/e737eff554ee433ca54835154fd67725fd52f63e/cli/src/main/java/org/jboss/as/cli/util/CLIExpressionResolver.java#L181] only checks null, but if there is an empty property as "APP-VERSION=", variable resolved is "". It continues to write <server name="TestProfile${SERVER-INSTANCE-NUMBER}test" group="TestProfile-server-group" auto-start="true"/> in configuration file without problem before next server reboot. It's an edge case to have empty value in properties file as reported case, however,  it'd better to throw an UnresolvedExpressionException with informative message.

> CLI does not resolve multiple properties if one property is undefined
> ---------------------------------------------------------------------
>
>                 Key: WFCORE-1198
>                 URL: https://issues.jboss.org/browse/WFCORE-1198
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 2.0.4.Final
>            Reporter: Chao Wang
>            Assignee: Chao Wang
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1289316 description:
> {noformat}
> Multiple property substitution is working with EAP 6.4.3+, however, if a variable amongst the multiple variables is empty or has no value, then the subsequent property in the CLI command is not substituted. 
> For example : 
> cat props.properties 
> -----------------------------------------
> PROFILE-NAME=TestProfile
> SERVER-INSTANCE-NUMBER=TestInstance
> APP-VERSION=
> VAR=test
> -----------------------------------------
> cat test.cli :
> ---------------------------------------
> /host=master/server-config=${PROFILE-NAME}${APP-VERSION}${SERVER-INSTANCE-NUMBER}${VAR}:add(auto-start=true, group="${PROFILE-NAME}${APP-VERSION}-server-group")
> ---------------------------------------
> and if I execute "./jboss-cli.sh --connect --file=test.cli --properties=props.properties" then I have the following in the host.xml ": 
> ----------
> ...
> <server name="TestProfile${SERVER-INSTANCE-NUMBER}test" group="TestProfile-server-group" auto-start="true"/>
> ...
> -----------
> Note APP-VERSION had no value, and so the subsequent SERVER-INSTANCE-NUMBER was not properly resolved
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)