[jboss-jira] [JBoss JIRA] (DROOLS-686) Documentation build: Upgrade pressgang-tools from 2 to 3

[Geoffrey De Smet (JIRA)]

    [ https://issues.jboss.org/browse/DROOLS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038434#comment-13038434 ] 

Geoffrey De Smet commented on DROOLS-686:
-----------------------------------------

Looks like Santos already solved the offline-doesn't-build issue:
  https://issues.jboss.org/browse/MPJDOCBOOK-84
PR on jdocbook-core but not yet released.

So what needs to happen is:
1) Release jdocbook-core 1.1.1 (Steve Ebersole or Strong Liu can release this).
2) Adjust maven-jdocbook-plugin to use that jdocbook-core version and release it. (I can do that release, but verify that the combo of everything works first)
3) Adjust droolsjbpm-build-bootstrap to use the that maven-jdocbook-plugin version and the latest pressgang-tools 3.x.

Petr (or MichaelB), if you can try everything locally by using snapshot builds of all these components and verify the offline docs build works, then chase people to do the release cascade (core first (Steve/Strong), then the plugin (me), then maybe pressgang-tools too if needed (also me)).

> Documentation build: Upgrade pressgang-tools from 2 to 3
> --------------------------------------------------------
>
>                 Key: DROOLS-686
>                 URL: https://issues.jboss.org/browse/DROOLS-686
>             Project: Drools
>          Issue Type: Task
>            Reporter: Geoffrey De Smet
>            Assignee: Petr Široký
>
> We're still using pressgang-tools 2:
>   https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/pom.xml#L409
> but some years ago pressgang-tools 3.x was build and released (by Steve Ebersole), which fixes some issues and enables some new features (such as topics in docbook):
>   https://github.com/pressgang/pressgang-tools
> However, pressgang-tools 3.x has an important regression in combination with the maven-docbook-plugin 2.3.8, which prevents building offline, which is a blocker for us:
>   https://issues.jboss.org/browse/PRESSGANG-79
> The interesting note is that the gradle-docbook-plugin does build offline, and that both plugins (maven and gradle) use the same jdocbook-core:
>   https://github.com/pressgang
> Goal: Fix that jira in maven-docbook-plugin and/or pressgang-tools, so droolsjbpm can upgrade to pressgang-tools 3.x. This is probably not easy.
> The reason that it doesn't build offline, is because the xslt's contain full-url imports, so it reaches out to download those, but the jdocbook-core is able to intercepts to calls and reroute them to the local resources in the pressgang-tools jar (instead of downloading them from the internet). For some reason that works (probably configured correctly) for the gradle plugin, but not for the maven plugin. It's also strange that the maven plugin does work correctly with pressgang 2 jars.
> In any case, the build should work offline (and doing "mvn -o" alone doesn't suffice to prove it, because the -o is ignored for the xslt stuff), plug out the network cable to verify it builds offline.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)