[jboss-jira] [JBoss JIRA] (WFCORE-466) Improve output of patch info command

Alexey Loubyansky (JIRA) issues at jboss.org
Fri Feb 6 15:06:49 EST 2015


    [ https://issues.jboss.org/browse/WFCORE-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038532#comment-13038532 ] 

Alexey Loubyansky commented on WFCORE-466:
------------------------------------------

I see a couple of issues here.

1. The format of the result is not user friendly and is already confusing to a human, I believe, unless you are very comfortable reading JSON. This is a command, not an operation where this kind of output is actually desired.

2. The confusion over the cumulative patch id and patches lies in the original patching terminology and patch structure that we accepted and implemented. Basically, a patch consists of smaller patches and a cumulative patch contains cumulative patches of the layers and addons, and they all have different IDs. There will always be some confusion unless we actually change the terminology.

What I am going to do about this is the following.

1. I will re-format the output into simple human friendly tables. But I will add an optional argument --json-format, which if present on the command line will instruct the CLI to output the result in the JSON format (useful for the tools and parsers). I think, I will hide it from the tab-completion though, for now.

2. I am just not going to display the layer and addon details by default. So, the output will be restricted only to the main current cumulative patch and the list of one-offs applied over it. The remaining details about layers and addons will be displayed in case the command line also contains --verbose.

> Improve output of patch info command
> ------------------------------------
>
>                 Key: WFCORE-466
>                 URL: https://issues.jboss.org/browse/WFCORE-466
>             Project: WildFly Core
>          Issue Type: Enhancement
>          Components: Patching 
>    Affects Versions: 1.0.0.Alpha1
>            Reporter: Martin Simka
>            Assignee: Alexey Loubyansky
>
> With connected CLI output of {{patch info}} command is:
> {noformat}
> [standalone at localhost:9999 /] patch info
> {
>     "outcome" : "success",
>     "result" : {
>         "cumulative-patch-id" : "jboss-eap-6.2.3.CP",
>         "patches" : [],
>         "version" : "6.2.3.GA",
>         "addon" : null,
>         "layer" : {"base" : {
>             "cumulative-patch-id" : "layer-base-jboss-eap-6.2.3.CP",
>             "patches" : []
>         }}
>     }
> }
> {noformat}
> Some users are confused by two elements cumulative-patch-id and they are not sure which id they should use e.g. with rollback command. 
> Output should be somehow improved but I don't have any suggestion. 



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)


More information about the jboss-jira mailing list