[jboss-jira] [JBoss JIRA] (WFLY-4359) WSEndpointDeploymentUnit should implement a WS-specific interface

[Alessio Soldano (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042271#comment-13042271 ] 

Alessio Soldano edited comment on WFLY-4359 at 2/20/15 6:22 AM:
----------------------------------------------------------------

Changing this would most likely mean wrapping any deployment unit that the WS subsystem processes into another object implementing a similar interface as the deployment mechanims was meant to work on DU and the DU was part of the AS ;-).

I take this as a part of the efforts for splitting WFCORE from the WLFY and can work on a solution for proper separation, if that's really required.

As a side note, to avoid misunderstandings, the WSEndpointDeploymentUnit is there to cover the minor scenario in which the Endpoint.publish() API is used in-container for programmatically starting an endpoint on the current server (that's why we create an equivalent to the deployment unit), not for normal EE deployments processing.


was (Author: asoldano):
Changing this would most likely mean wrapping any deployment unit that the WS subsystem processes into another object implementing a similar interface as the deployment mechanims was meant to work on DU and the DU was part of the AS ;-).
I take this as a part of the efforts for splitting WFCORE from the WLFY and can work on a solution for proper separation, if that's really required.

> WSEndpointDeploymentUnit should implement a WS-specific interface
> -----------------------------------------------------------------
>
>                 Key: WFLY-4359
>                 URL: https://issues.jboss.org/browse/WFLY-4359
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web Services
>            Reporter: Brian Stansberry
>            Assignee: Alessio Soldano
>
> WSEndpointDeploymentUnit implements the DeploymentUnit interface, but not really. A bunch of methods throw UnsupportedOperationException.
> This tells me it's using that interface as a minor short-cut, not because it's truly meant to be a DeploymentUnit impl.
> This is the only impl of this interface outside of WFCORE, and having it here makes it harder to evolve the interface.
> The WS subsystem code should use its own interface (e.g. as a param to WSDeploymentBuilder.build()), and for the call paths that want to use the DeploymentUnit from WFCORE, wrap the DU in an impl of this WS interface and delegate to it.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)