[jboss-jira] [JBoss JIRA] (WFLY-4359) WSEndpointDeploymentUnit should implement a WS-specific interface

[Alessio Soldano (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042388#comment-13042388 ] 

Alessio Soldano commented on WFLY-4359:
---------------------------------------

Brian, this [1] is how it could be modified, not that I like the changes that much ;-) The modified version does not compile, though, as my WSDeploymentUnit still needs to be passed into EjbDeploymentMarker.isEjbDeployment(...) and DeploymentTypeMarker.isType(...) which are part of WFCORE. So that would need to be modified there first.

[1] https://github.com/asoldano/wildfly/commit/b65f297a961a3dd974209896d52f076ad34cdc2a

> WSEndpointDeploymentUnit should implement a WS-specific interface
> -----------------------------------------------------------------
>
>                 Key: WFLY-4359
>                 URL: https://issues.jboss.org/browse/WFLY-4359
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web Services
>            Reporter: Brian Stansberry
>            Assignee: Alessio Soldano
>
> WSEndpointDeploymentUnit implements the DeploymentUnit interface, but not really. A bunch of methods throw UnsupportedOperationException.
> This tells me it's using that interface as a minor short-cut, not because it's truly meant to be a DeploymentUnit impl.
> This is the only impl of this interface outside of WFCORE, and having it here makes it harder to evolve the interface.
> The WS subsystem code should use its own interface (e.g. as a param to WSDeploymentBuilder.build()), and for the call paths that want to use the DeploymentUnit from WFCORE, wrap the DU in an impl of this WS interface and delegate to it.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)