[jboss-jira] [JBoss JIRA] (WFLY-4359) WSEndpointDeploymentUnit should implement a WS-specific interface

[Brian Stansberry (JIRA)]

     [ https://issues.jboss.org/browse/WFLY-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry resolved WFLY-4359.
------------------------------------
    Resolution: Rejected


Thanks for the input, and sorry for sucking in your time.

The fact you're handing this object back out again to core proves you need an interface from core. Attachable could work, but if you have to do that, and core has to modify its APIs to take Attachable instead of DU --- well, it's just too smelly.

I think the smell comes from the DU methods that WSEndpointDeploymentUnit isn't implementing, and the newer variants that we need. They aren't a nice fit with the DU interface. So James Perkins is instead going to try and deprecate the existing ones and add a separate API for the newer ones.

> WSEndpointDeploymentUnit should implement a WS-specific interface
> -----------------------------------------------------------------
>
>                 Key: WFLY-4359
>                 URL: https://issues.jboss.org/browse/WFLY-4359
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web Services
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>
> WSEndpointDeploymentUnit implements the DeploymentUnit interface, but not really. A bunch of methods throw UnsupportedOperationException.
> This tells me it's using that interface as a minor short-cut, not because it's truly meant to be a DeploymentUnit impl.
> This is the only impl of this interface outside of WFCORE, and having it here makes it harder to evolve the interface.
> The WS subsystem code should use its own interface (e.g. as a param to WSDeploymentBuilder.build()), and for the call paths that want to use the DeploymentUnit from WFCORE, wrap the DU in an impl of this WS interface and delegate to it.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)