[jboss-jira] [JBoss JIRA] (WFCORE-565) StaticDiscoveryResourceDefinition allows undefined values for its attributes

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043700#comment-13043700 ] 

Brian Stansberry commented on WFCORE-565:
-----------------------------------------

DiscoveryOptionStrategy.DiscoveryOptionComparator will fail if protocol or port are null for any DiscoveryOption. 

> StaticDiscoveryResourceDefinition allows undefined values for its attributes
> ----------------------------------------------------------------------------
>
>                 Key: WFCORE-565
>                 URL: https://issues.jboss.org/browse/WFCORE-565
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>            Reporter: Brian Stansberry
>
> StaticDiscoveryResourceDefinition reuses the AttributeDefinitions from RemoteDomainControllerAddHandler, but those ADs allow undefined. That's appropriate for that OSH, but not for the StaticDiscoveryResourceDefinition ADs.
> Also, the RemoteDomainControllerAddHandler AD's could use some clarification and validation as well, e.g. use setRequires(...) on the builder such that each of protocol, host, port requires the other two. So none are required, but if any is set all 3 must be.
> The StaticDiscovery constructor should validate inputs with assert statements and javadoc its parameters, include whether null is allowed. (A null protocol or host will result in an IAE in discover(), so the current code does not support null.)
> The DiscoveryOption interface should document whether the 3 "get" methods can return null.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)