[jboss-jira] [JBoss JIRA] (WFLY-4305) Script rumbles on after error

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044507#comment-13044507 ] 

Tom Jenkinson commented on WFLY-4305:
-------------------------------------

Hi Carlo, I think the solution needs a bit more work. 

For example:
https://github.com/wildfly/wildfly/blob/master/tools/download-maven.sh#L12
There is logic to handle deleting old versions of maven that are not compatible but they don't execute because the grep fails.

Also: https://github.com/wildfly/wildfly/blob/master/build.sh#L108
On MacOS "ulimit -n $MAX_FD" fails as by then MAX_FD is set to "maximum" which is not a valid identifier on MacOS.
First I knew of it was when my CI build on the teams Mac slave started failing whereas previously it would have "warn"ed

> Script rumbles on after error
> -----------------------------
>
>                 Key: WFLY-4305
>                 URL: https://issues.jboss.org/browse/WFLY-4305
>             Project: WildFly
>          Issue Type: Bug
>          Components: Build System
>            Reporter: Carlo de Wolf
>            Assignee: Carlo de Wolf
>             Fix For: 9.0.0.Beta1
>
>
> After a failure in the script it rumbles on.
> {noformat}
> (master) carlo at devel01:~/work/wildfly$ ./build.sh clean
> ./tools/download-maven.sh: 20: ./tools/download-maven.sh: curl: not found
> Archive:  maven.zip
>   End-of-central-directory signature not found.  Either this file is not
>   a zipfile, or it constitutes one disk of a multi-part archive.  In the
>   latter case the central directory and zipfile comment will be found on
>   the last disk(s) of this archive.
> unzip:  cannot find zipfile directory in one of maven.zip or
>         maven.zip.zip, and cannot find maven.zip.ZIP, period.
> mv: cannot stat ‘apache-maven*’: No such file or directory
> build.sh: Could not locate Maven; check $MVN or $MAVEN_HOME.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)