[jboss-jira] [JBoss JIRA] (WFCORE-502) Eliminate requirement for OperationStepHandler.execute to call completeStep/stepCompleted

[Brian Stansberry (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry updated WFCORE-502:
------------------------------------
    Description: 
The requirement that an OSH call completeStep/stepCompleted in its execute method dates from when we supported recursive step execution. It could have been eliminated when we dropped support for recursive step execution, but that didn't occur to me until yesterday.

All stepCompleted() does is register a default ResultHandler. AbstractOperationContext.executeStep could do the same thing after calling step.execute(...) if that call returns normally and it sees that no ResultHandler was registered with the step.

Even I fairly often make the mistake of forgetting to add a stepCompleted call.

  was:
The requirement that an OSH call completeStep/stepCompleted in its execute method dates from when we supported recursive step execution. It could have been eliminated when we dropped support for recursive step execution.

All stepCompleted() does is register a default ResultHandler. AbstractOperationContext.executeStep could do the same thing after calling step.execute(...) if that call returns normally and it sees that no ResultHandler was registered with the step.

Even I fairly often make the mistake of forgetting to add a stepCompleted call.



> Eliminate requirement for OperationStepHandler.execute to call completeStep/stepCompleted
> -----------------------------------------------------------------------------------------
>
>                 Key: WFCORE-502
>                 URL: https://issues.jboss.org/browse/WFCORE-502
>             Project: WildFly Core
>          Issue Type: Enhancement
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>             Fix For: 1.0.0.Beta1
>
>
> The requirement that an OSH call completeStep/stepCompleted in its execute method dates from when we supported recursive step execution. It could have been eliminated when we dropped support for recursive step execution, but that didn't occur to me until yesterday.
> All stepCompleted() does is register a default ResultHandler. AbstractOperationContext.executeStep could do the same thing after calling step.execute(...) if that call returns normally and it sees that no ResultHandler was registered with the step.
> Even I fairly often make the mistake of forgetting to add a stepCompleted call.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)