[jboss-jira] [JBoss JIRA] (WFLY-4878) ORB subsystem wrongly compare ModelNode property

[Ondřej Chaloupka (JIRA)]

Ondřej Chaloupka created WFLY-4878:
--------------------------------------

             Summary: ORB subsystem wrongly compare ModelNode property
                 Key: WFLY-4878
                 URL: https://issues.jboss.org/browse/WFLY-4878
             Project: WildFly
          Issue Type: Bug
          Components: IIOP
            Reporter: Ondřej Chaloupka
            Assignee: Tomasz Adamski


It seems that wrong type comparision is used in TransformUtils class [1] when model node attribute is verified {{if(!value.equals("off")) ...}}

When looking at ModelNode code of {{equal}} method [2] it seems that the comparistion will be false in any case.

Found out during static code analyzis check.

[1] https://github.com/wildfly/wildfly/blob/master/legacy/jacorb/src/main/java/org/jboss/as/jacorb/TransformUtils.java#L84
[2] https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/dmr/ModelNode.java#L1575



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)