[jboss-jira] [JBoss JIRA] (WFCORE-779) AbstractAddStepHandler doesn't let AttributeDefinitions record default capability requirements

[Brian Stansberry (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry updated WFCORE-779:
------------------------------------
    Git Pull Request: https://github.com/wildfly/wildfly-core/pull/869  (was: https://github.com/wildfly/wildfly-core/pull/838)


> AbstractAddStepHandler doesn't let AttributeDefinitions record default capability requirements
> ----------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-779
>                 URL: https://issues.jboss.org/browse/WFCORE-779
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 2.0.0.Alpha4
>            Reporter: Brian Stansberry
>            Assignee: Tomaz Cerar
>            Priority: Minor
>             Fix For: 2.0.0.Alpha7
>
>
> AbstractAddStepHandler.recordCapabilitiesAndRequirements(...) has this:
> {code}
>         ModelNode model = resource.getModel();
>         for (AttributeDefinition ad : attributes) {
>             if (model.hasDefined(ad.getName())) {
>                 ad.addCapabilityRequirements(context, model.get(ad.getName()));
>             }
>         }
> {code}
> That 'if' check removes the opportunity for an AD to register a requirement based on the default value of the attribute.
> SimpleAttributeDefinition includes logic for doing that, so not giving it a chance to execute is inconsistent. AbstractWriteAttributeHandler also doesn't include any such limitation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)