[jboss-jira] [JBoss JIRA] (WFLY-4878) ORB subsystem wrongly compare ModelNode property

[Tomasz Adamski (JIRA)]

     [ https://issues.jboss.org/browse/WFLY-4878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomasz Adamski closed WFLY-4878.
--------------------------------
    Fix Version/s: 10.0.0.Alpha5
       Resolution: Done


> ORB subsystem wrongly compare ModelNode property
> ------------------------------------------------
>
>                 Key: WFLY-4878
>                 URL: https://issues.jboss.org/browse/WFLY-4878
>             Project: WildFly
>          Issue Type: Bug
>          Components: IIOP
>            Reporter: Ondřej Chaloupka
>            Assignee: Tomasz Adamski
>             Fix For: 10.0.0.Alpha5
>
>
> It seems that wrong type comparision is used in TransformUtils class [1] when model node attribute is verified {{if(!value.equals("off")) ...}}
> When looking at ModelNode code of {{equal}} method [2] it seems that the comparistion will be false in any case.
> Found out during static code analyzis check.
> [1] https://github.com/wildfly/wildfly/blob/master/legacy/jacorb/src/main/java/org/jboss/as/jacorb/TransformUtils.java#L84
> [2] https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/dmr/ModelNode.java#L1575



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)