[jboss-jira] [JBoss JIRA] (WFLY-4445) Remove "path" and "relative-to" attributes from CLI from transactions subsystem

Brian Stansberry (JIRA) issues at jboss.org
Mon Jul 13 10:12:05 EDT 2015


    [ https://issues.jboss.org/browse/WFLY-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088884#comment-13088884 ] 

Brian Stansberry commented on WFLY-4445:
----------------------------------------

I believe you need to modify the various TransactionSubsystemXXParser classes for the xsd versions that declared support for these attributes. Change the handling so that instead of this kind of thing:

{code}
            switch (attribute) {
                case PATH:
                    TransactionSubsystemRootResourceDefinition.PATH.parseAndSetParameter(value, operation, reader);
                    break;
                case RELATIVE_TO:
                    TransactionSubsystemRootResourceDefinition.RELATIVE_TO.parseAndSetParameter(value, operation, reader);
                    break;
{code}

instead they throw a nicely worded XmlStreamException explaining that 'attribute' is no longer supported and the location in the xml doc where the flaw occurred. The latter is available by calling 'reader.getLocation()'.

That will provide a properly helpful failure to anyone who tries to use an old config that has these attribute defined. That should be rare, as these attributes weren't in our standard configs and they never did anything that would lead someone to add them.

Next step is to edit the config files used by the various transaction module unit tests to remove those attributes. The tests will fail so long as they are present, as the code doesn't support them.

> Remove "path" and "relative-to" attributes from CLI from transactions subsystem
> -------------------------------------------------------------------------------
>
>                 Key: WFLY-4445
>                 URL: https://issues.jboss.org/browse/WFLY-4445
>             Project: WildFly
>          Issue Type: Feature Request
>          Components: Domain Management, Transactions
>            Reporter: Ondřej Chaloupka
>            Assignee: Amos Feng
>             Fix For: 10.0.0.Alpha6
>
>
> As "process-id/file" functionality is not yet added in EAP, the "path" and "relative-to" attributes are useless in transactions subsystem of CLI.
> Please remove them.
> Also please remove them from "jboss-as-txn***.xsd" file as well.
> For detailed discussion please refer to https://bugzilla.redhat.com/show_bug.cgi?id=1039081



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)



More information about the jboss-jira mailing list