[jboss-jira] [JBoss JIRA] (WFCORE-839) Don't store state in InMemoryAuditLogHandlerResourceDefinition

[ehsavoie Hugonnet (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ehsavoie Hugonnet reassigned WFCORE-839:
----------------------------------------

    Assignee: ehsavoie Hugonnet  (was: Brian Stansberry)


> Don't store state in InMemoryAuditLogHandlerResourceDefinition
> --------------------------------------------------------------
>
>                 Key: WFCORE-839
>                 URL: https://issues.jboss.org/browse/WFCORE-839
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 2.0.0.Alpha11
>            Reporter: ehsavoie Hugonnet
>            Assignee: ehsavoie Hugonnet
>            Priority: Minor
>
> https://github.com/wildfly/wildfly-core/pull/890#discussion_r35354989
>  private static final Map<String, InMemoryAuditLogHander> histories = Collections.synchronizedMap(new HashMap<String, InMemoryAuditLogHander>());
> We don't want to delay merging this PR for this, but once it's merged please send up a PR to make this a non-static field and have the InMemoryAuditLogHandlerResourceDefinition pass a ref to it to the handlers when it constructs them.
> Having this be static is no big deal in this case, but I don't want anyone looking at kernel code and thinking that using static fields to store state is a good practice.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)