[jboss-jira] [JBoss JIRA] (WFLY-4850) ManagementClient.isServerInRunningState fails when server is stopped

[James Perkins (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093665#comment-13093665 ] 

James Perkins commented on WFLY-4850:
-------------------------------------

The [container is stopped|https://github.com/wildfly/wildfly/blob/master/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/extended/ejb2/stateful/passivation/ClusterPassivationTestBase.java#L160-160] which closes the client being used. Then there's an attempt to execute the operation on a closed client. The {{ManagementClient}} should probably throw an exception if there is an attempt to use the client after it's been closed. The test behavior is incorrect as well as the client should be fixed to throw a better exception.

For documentation purposes the stack trace is:
{code}
testPassivationBeanAnnotated(org.jboss.as.test.clustering.extended.ejb2.stateful.passivation.ClusterPassivationTestCase)  Time elapsed: 80.254 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.jboss.as.protocol.mgmt.ActiveOperationSupport.registerActiveOperation(ActiveOperationSupport.java:152)
	at org.jboss.as.protocol.mgmt.ActiveOperationSupport.registerActiveOperation(ActiveOperationSupport.java:121)
	at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:121)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeRequest(AbstractModelControllerClient.java:263)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:168)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
	at org.jboss.as.arquillian.container.ManagementClient.isServerInRunningState(ManagementClient.java:215)
	at org.jboss.as.test.clustering.extended.ejb2.stateful.passivation.ClusterPassivationTestCase.startServers(ClusterPassivationTestCase.java:91)
	at org.jboss.as.test.clustering.extended.ejb2.stateful.passivation.ClusterPassivationTestCase.testPassivationBeanAnnotated(ClusterPassivationTestCase.java:144)

stopAndClean(org.jboss.as.test.clustering.extended.ejb2.stateful.passivation.ClusterPassivationTestCase)  Time elapsed: 78.804 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.jboss.as.protocol.mgmt.ActiveOperationSupport.registerActiveOperation(ActiveOperationSupport.java:152)
	at org.jboss.as.protocol.mgmt.ActiveOperationSupport.registerActiveOperation(ActiveOperationSupport.java:121)
	at org.jboss.as.protocol.mgmt.ManagementChannelHandler.executeRequest(ManagementChannelHandler.java:121)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeRequest(AbstractModelControllerClient.java:263)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:168)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.executeForResult(AbstractModelControllerClient.java:147)
	at org.jboss.as.controller.client.impl.AbstractModelControllerClient.execute(AbstractModelControllerClient.java:75)
	at org.jboss.as.arquillian.container.ManagementClient.isServerInRunningState(ManagementClient.java:215)
	at org.jboss.as.test.clustering.extended.ejb2.stateful.passivation.ClusterPassivationTestCase.stopAndClean(ClusterPassivationTestCase.java:165)
{code}


> ManagementClient.isServerInRunningState fails when server is stopped
> --------------------------------------------------------------------
>
>                 Key: WFLY-4850
>                 URL: https://issues.jboss.org/browse/WFLY-4850
>             Project: WildFly
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Ondřej Chaloupka
>            Assignee: James Perkins
>
> Scenario: server is stopped (killed), working with arquillian to check if server is started or not
> Current implementation of the {{ManagementClient.isServerInRunningState}} catches only {{IOException}} (see [1]) and in such case false is returned. Otherwise exception is propagated upwards.
> That's a problem in case that assertions are enabled - which is true statement for wildfly testsuite (see pom.xml, surefire configuration and {{<enableAssertions>true</enableAssertions>}}). As state of the server is checked with assertions as well [2] then test fails on such assertion instead of getting false as server is stopped.
> In comparision with arquillian client for jboss-eap there is caught {{Throwable}} and returned false [3] which seems to me more correct.
> Could you, please, forwardport arquillian client behaviour from JBoss EAP to WildFly?
> [1] https://github.com/wildfly/wildfly-arquillian/blob/master/common/src/main/java/org/jboss/as/arquillian/container/ManagementClient.java#L197
> [2] https://github.com/wildfly/wildfly-core/blob/master/protocol/src/main/java/org/jboss/as/protocol/mgmt/ActiveOperationSupport.java#L151
> [3] https://github.com/jbossas/jboss-eap/blob/6.x/arquillian/common/src/main/java/org/jboss/as/arquillian/container/ManagementClient.java#L177



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)