[jboss-jira] [JBoss JIRA] (WFLY-4697) EJBCLient access to SFSBs does not play well with clean shutdown

[Richard Achmatowicz (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076972#comment-13076972 ] 

Richard Achmatowicz edited comment on WFLY-4697 at 6/10/15 1:01 PM:
--------------------------------------------------------------------

The server can be subject to these activities:
suspend/resume
deploy/undeploy
shutdown

When we deploy/undeploy, we send protocol messages to the clients indicating that the module is unavailable or available. This influences which servers receive invocations.  

When we suspend/resume, no protocol messages are sent to clients indicating that the module is unavailable or available. Instead, we rely on processing of  EJBComponentNotAvailableException, so at least we should do. This is translated into a NoSuchEJBException by the invocation handler, so that the client may retry on another node. However, this will case the node to be excluded from all client contexts which attempt to access it while suspended, and when the node is resumed, it will stay excluded.
 



was (Author: rachmato):
The server can be subject to these activities:
suspend/resume
deploy/undeploy
shutdown

When we deploy/undeploy, we send protocol messages to the clients indicating that the module is unavailable or available. This influences which servers receive invocations.  
When we suspend/resume, no protocol messages are sent to clients indicating that the module is unavailable or available. Instead, we rely on processing of  EJBComponentNotAvailableException, so at least we should do. This is translated into a NoSuchEJBException by the invocation handler, so that the client may retry on another node.


> EJBCLient access to SFSBs does not play well with clean shutdown
> ----------------------------------------------------------------
>
>                 Key: WFLY-4697
>                 URL: https://issues.jboss.org/browse/WFLY-4697
>             Project: WildFly
>          Issue Type: Bug
>          Components: Clustering, EJB, Remoting
>    Affects Versions: 10.0.0.Alpha1
>            Reporter: Richard Achmatowicz
>            Assignee: Richard Achmatowicz
>
> The clean shutdown mechanism allows EJB and web applications to make use of shutdown interceptors to allow the application server to refuse requests when a server is in the process of shutting down. These interceptors are tied to the processing of EJB invocations and web requests.
> In the case of EJBCLient invocations, they arrive at the remoting connector, and undergo some preliminary processing before being sent to the EJB interface in question. When a server is shutting down, EJBCLient invocations can arrive at the RemoteConnector and start processing, even when the EJB interface has been locked down, so to speak.
> I am seeing various types of exceptions arising from this preliminary processing (e.g. NPE on DeploymentRepository lookups) and these get returned to the client as exceptions on the SFSB invocation, before even reaching the SFSB interceptors.
> If the EJBCLient is running in a managed transaction context, these returned exceptions will case the SFSB to be discarded (as the SFSB invocation is considered failed with the exception returned) and the transaction will attempt to rollback. If the rollback processing fails (because the original node in the transaction is down the bean gets removed anyway. The SFSB session state is lost, even if there is another node in the cluster which can support the invocation.
> In short, it looks as though the clean shutdown mechanism needs to be used to also lock down the processing of EJBCLient invocations in some way.
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)