[jboss-jira] [JBoss JIRA] (WFLY-1119) Assign an unique NodeID automatically

[Amos Feng (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045564#comment-13045564 ] 

Amos Feng commented on WFLY-1119:
---------------------------------

{code}
public static final SimpleAttributeDefinition NODE_IDENTIFIER = new SimpleAttributeDefinitionBuilder(CommonAttributes.NODE_IDENTIFIER, ModelType.STRING, true)
            .setDefaultValue(new ModelNode().set("1"))
            .setFlags(AttributeAccess.Flag.RESTART_ALL_SERVICES)
            .setAllowExpression(true)
            .setValidator(new StringBytesLengthValidator(0,23,true,true))
            .build();
{code}
So it should remove the default value and if the node-identifier is undefined we need to generate a true uuid and persist in the standalone.xml
It looks like the max length for node-name is 24 ?

I will take a look at the way to check attributes of other servers.



> Assign an unique NodeID automatically
> -------------------------------------
>
>                 Key: WFLY-1119
>                 URL: https://issues.jboss.org/browse/WFLY-1119
>             Project: WildFly
>          Issue Type: Feature Request
>          Components: Transactions
>            Reporter: Clebert Suconic
>            Assignee: Amos Feng
>            Priority: Optional
>
> It shouldn't be needed to assign the node-id manually IMO.
> You could store the node-id on a file and recover it for subsequent starts.
> On hornetQ for instance, we look for the nodeID on a file, if the file doesn't exist we assign a UUID and write to the file.
> In our previous experience UUID would be a best fit to assign the nodes since that was the only way we could guarantee unique IDs between the nodes.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)