[jboss-jira] [JBoss JIRA] (WFCORE-572) Review usage of the two different NoSuchResourceException's

[James Perkins (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Perkins updated WFCORE-572:
---------------------------------
    Description: 
There are two versions of the {{NoSuchResourceException}}, [{{org.jboss.as.controller.NoSuchResourceException}}|https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/NoSuchResourceException.java] and [{{org.jboss.as.controller.registry.Resource.NoSuchResourceException}}|https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/registry/Resource.java#L299]. The usages should be reviewed as some code seems to catch one where the other is likely thrown.

>From HipChat:
{quote}
Brian Stansberry
8:40 AM
it's the NoSuchElementException aspect we should get rid of
BasicResource threw that when it was first written, so then it got added to javadoc and the registry.resource one extended it to preserve compatibility
it should all go to the org.jboss.as.controller.NoSuchResourceException one
the registry.resource one can just be deprecated and extend org.jboss.as.controller.NoSuchResourceException, no more NoSuchElementException
{quote}

  was:
There are two versions of the {{NoSuchResourceException}}, [{{org.jboss.as.controller.NoSuchResourceException}}|https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/NoSuchResourceException.java] and [{{org.jboss.as.controller.registry.Resource.NoSuchResourceException}}|https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/registry/Resource.java#L299]. The usages should be reviewed as some code seems to catch one where the other is likely thrown.

>From HipChat:
{quote}
Brian Stansberry
8:40 AM
BasicResource threw that when it was first written, so then it got added to javadoc and the registry.resource one extended it to preserve compatibility
it should all go to the org.jboss.as.controller.NoSuchResourceException one
the registry.resource one can just be deprecated and extend org.jboss.as.controller.NoSuchResourceException, no more NoSuchElementException
{quote}



> Review usage of the two different NoSuchResourceException's
> -----------------------------------------------------------
>
>                 Key: WFCORE-572
>                 URL: https://issues.jboss.org/browse/WFCORE-572
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Domain Management
>            Reporter: James Perkins
>            Assignee: Brian Stansberry
>
> There are two versions of the {{NoSuchResourceException}}, [{{org.jboss.as.controller.NoSuchResourceException}}|https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/NoSuchResourceException.java] and [{{org.jboss.as.controller.registry.Resource.NoSuchResourceException}}|https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/registry/Resource.java#L299]. The usages should be reviewed as some code seems to catch one where the other is likely thrown.
> From HipChat:
> {quote}
> Brian Stansberry
> 8:40 AM
> it's the NoSuchElementException aspect we should get rid of
> BasicResource threw that when it was first written, so then it got added to javadoc and the registry.resource one extended it to preserve compatibility
> it should all go to the org.jboss.as.controller.NoSuchResourceException one
> the registry.resource one can just be deprecated and extend org.jboss.as.controller.NoSuchResourceException, no more NoSuchElementException
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)