[jboss-jira] [JBoss JIRA] (JGRP-1920) FC: Flag NO_FC is not applied on RPC calls/responses

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049265#comment-13049265 ] 

Bela Ban commented on JGRP-1920:
--------------------------------

Can you give more details ? Looking at {{MessageDispatcher.cast()}}, the flags of {{RequestOptions}} are actually copied into the request message:

{noformat}
protected <T> GroupRequest<T> cast(final Collection<Address> dests, Message msg, RequestOptions options,
                                       boolean block_for_results, FutureListener<RspList<T>> listener) throws Exception {
    
        if(options != null) {
            msg.setFlag(options.getFlags()).setTransientFlag(options.getTransientFlags());
            if(options.getScope() > 0)
                msg.setScope(options.getScope());
        }
...
{noformat}

Also, in {{RequestCorrelator.sendReply()}}, the flags of the request message are copied into the response message:
{noformat}
Message rsp=req.makeReply().setFlag(req.getFlags()).clearFlag(Message.Flag.RSVP, Message.Flag.SCOPED);
{noformat}

> FC: Flag NO_FC is not applied on RPC calls/responses
> ----------------------------------------------------
>
>                 Key: JGRP-1920
>                 URL: https://issues.jboss.org/browse/JGRP-1920
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Karim AMMOUS
>            Assignee: Bela Ban
>             Fix For: 3.6.3
>
>
> When we set Flag.NO_FC on an RPC call through "RequestOptions", we expect that both request and response will be not rate limited.
> Currently, both request and response could be slow down by flow control protocols.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)