[jboss-jira] [JBoss JIRA] (DROOLS-745) Unnecessary and thread-blocking "synchronized" in MVELSafeHelper.java

Andrey Bichkevskiy (JIRA) issues at jboss.org
Tue Mar 17 23:25:19 EDT 2015


Andrey Bichkevskiy created DROOLS-745:
-----------------------------------------

             Summary: Unnecessary and thread-blocking "synchronized" in MVELSafeHelper.java
                 Key: DROOLS-745
                 URL: https://issues.jboss.org/browse/DROOLS-745
             Project: Drools
          Issue Type: Bug
          Components: core engine
    Affects Versions: 6.2.0.Final
            Reporter: Andrey Bichkevskiy
            Assignee: Mario Fusco


Class org.drools.core.util.MVELSafeHelper, obsolete and thread-blocking "synchronized" keyword in static getter of a static final field:

public class MVELSafeHelper {
    private static final MVELEvaluator evaluator;
    static {
        evaluator = KiePolicyHelper.isPolicyEnabled() ? new SafeMVELEvaluator() : new RawMVELEvaluator();
    }
    public static synchronized MVELEvaluator getEvaluator() {
        return evaluator;
    }
//
}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)


More information about the jboss-jira mailing list