[jboss-jira] [JBoss JIRA] (DROOLS-745) Unnecessary and thread-blocking "synchronized" in MVELSafeHelper.java

Mario Fusco (JIRA) issues at jboss.org
Fri Mar 20 06:17:18 EDT 2015


     [ https://issues.jboss.org/browse/DROOLS-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mario Fusco resolved DROOLS-745.
--------------------------------
    Fix Version/s: 6.3.0.Beta1
       Resolution: Done


Fixed by https://github.com/droolsjbpm/drools/commit/1beb00549

> Unnecessary and thread-blocking "synchronized" in MVELSafeHelper.java
> ---------------------------------------------------------------------
>
>                 Key: DROOLS-745
>                 URL: https://issues.jboss.org/browse/DROOLS-745
>             Project: Drools
>          Issue Type: Bug
>          Components: core engine
>    Affects Versions: 6.2.0.Final
>            Reporter: Andrey Bichkevskiy
>            Assignee: Mario Fusco
>              Labels: drools-core
>             Fix For: 6.3.0.Beta1
>
>   Original Estimate: 5 minutes
>  Remaining Estimate: 5 minutes
>
> Class org.drools.core.util.MVELSafeHelper, obsolete and thread-blocking "synchronized" keyword in static getter of a static final field:
> public class MVELSafeHelper {
>     private static final MVELEvaluator evaluator;
>     static {
>         evaluator = KiePolicyHelper.isPolicyEnabled() ? new SafeMVELEvaluator() : new RawMVELEvaluator();
>     }
>     public static synchronized MVELEvaluator getEvaluator() {
>         return evaluator;
>     }
> //
> }



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)


More information about the jboss-jira mailing list