[jboss-jira] [JBoss JIRA] (JBJCA-1257) SemaphoreConcurrentLinkedQueueManagedConnectionPool

[Radim Vansa (JIRA)]

     [ https://issues.jboss.org/browse/JBJCA-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Radim Vansa updated JBJCA-1257:
-------------------------------
    Description: 
With SemaphoreConcurrentLinkedQueueManagedConnectionPool, if creating a new connection fails with exception, logging this 
{code}
log.throwableWhileTryingMatchManagedConnectionThenDestroyingConnection(clw.getConnectionListener(), t);
{code}

https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L338

causes NPE since clw == null. This way, the NPE is eventually swallowed on https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L437 and only generic ResourceException (without much info) is thrown.

  was:
With SemaphoreConcurrentLinkedQueueManagedConnectionPool, if creating a new connection fails with exception, logging this 
{code}
log.throwableWhileTryingMatchManagedConnectionThenDestroyingConnection(clw.getConnectionListener(), t);
{code}

https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L338

causes NPE since clw == null.



> SemaphoreConcurrentLinkedQueueManagedConnectionPool
> ---------------------------------------------------
>
>                 Key: JBJCA-1257
>                 URL: https://issues.jboss.org/browse/JBJCA-1257
>             Project: IronJacamar
>          Issue Type: Feature Request
>          Components: Core
>    Affects Versions: 1.0.31.Final
>            Reporter: Radim Vansa
>            Assignee: Jesper Pedersen
>            Priority: Minor
>
> With SemaphoreConcurrentLinkedQueueManagedConnectionPool, if creating a new connection fails with exception, logging this 
> {code}
> log.throwableWhileTryingMatchManagedConnectionThenDestroyingConnection(clw.getConnectionListener(), t);
> {code}
> https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L338
> causes NPE since clw == null. This way, the NPE is eventually swallowed on https://github.com/ironjacamar/ironjacamar/blob/1.0/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedQueueManagedConnectionPool.java#L437 and only generic ResourceException (without much info) is thrown.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)