[jboss-jira] [JBoss JIRA] (DROOLS-751) Missing nullchecks in LeftTupleSetsImpl

[Tibor Zimányi (JIRA)]

    [ https://issues.jboss.org/browse/DROOLS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053744#comment-13053744 ] 

Tibor Zimányi commented on DROOLS-751:
--------------------------------------

Found because of failed test (MultithreadTest): 

java.lang.NullPointerException
	at org.drools.core.common.LeftTupleSetsImpl.removeInsert(LeftTupleSetsImpl.java:136)
	at org.drools.core.common.LeftTupleSetsImpl.addDelete(LeftTupleSetsImpl.java:86)
	at org.drools.core.common.SynchronizedLeftTupleSets.addDelete(SynchronizedLeftTupleSets.java:20)
	at org.drools.core.reteoo.LeftInputAdapterNode.doDeleteSegmentMemory(LeftInputAdapterNode.java:340)
	at org.drools.core.reteoo.LeftInputAdapterNode.doDeleteObject(LeftInputAdapterNode.java:302)
	at org.drools.core.reteoo.LeftInputAdapterNode.retractLeftTuple(LeftInputAdapterNode.java:414)
	at org.drools.core.reteoo.ObjectTypeNode.doRetractObject(ObjectTypeNode.java:354)
	at org.drools.core.reteoo.ObjectTypeNode.retractObject(ObjectTypeNode.java:337)
	at org.drools.core.reteoo.EntryPointNode.retractObject(EntryPointNode.java:381)
	at org.drools.core.common.NamedEntryPoint.delete(NamedEntryPoint.java:615)
	at org.drools.core.impl.StatefulKnowledgeSessionImpl.delete(StatefulKnowledgeSessionImpl.java:1517)
	at org.drools.core.impl.StatefulKnowledgeSessionImpl.retract(StatefulKnowledgeSessionImpl.java:1502)
	at org.drools.compiler.integrationtests.MultithreadTest$2.call(MultithreadTest.java:92)
	at org.drools.compiler.integrationtests.MultithreadTest$2.call(MultithreadTest.java:86)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

> Missing nullchecks in LeftTupleSetsImpl
> ---------------------------------------
>
>                 Key: DROOLS-751
>                 URL: https://issues.jboss.org/browse/DROOLS-751
>             Project: Drools
>          Issue Type: Bug
>            Reporter: Tibor Zimányi
>            Assignee: Mark Proctor
>
> In class LeftTupleSetsImpl there are missing nullchecks in some methods that contains handling LeftTuple instances. I.e. in method removeInsert there is LeftTuple variable previous that is not nullchecked.  



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)