[jboss-jira] [JBoss JIRA] (JGRP-1926) ForkChannel needs to call init() and start() correctly on all added protocols

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071896#comment-13071896 ] 

Bela Ban edited comment on JGRP-1926 at 5/28/15 7:53 AM:
---------------------------------------------------------

Ref counting is now done: the first ForkChannel's creation causes all fork protocols' {{init()}} method to be called, calling {{close()}} on the last ForkChannel causes the stack to be destroyed, with {{destroy()}} getting called on all fork protocols before.
{{ForkChannel}}.{{connect()}}/{{disconnect()}} is also ref-counted: the first {{connect()}} calls {{start)}} in all fork protocols, and the last {{disconnect()}} calls {{stop()}}.


was (Author: belaban):
Ref counting is now done: the first ForkChannel's creation causes all fork protcols' {{init()}} method to be called, calling {{close()}} on the last ForkChannel causes the stack to be destroyed, with {{destroy()}} getting called on all fork protocols before.
{{ForkChannel}}.{{connect()}}/{{disconnect()}} is also ref-counted: the first {{connect()}} calls {{start)}} in all fork protocols, and the last {{disconnect()}} calls {{stop()}}.

> ForkChannel needs to call init() and start() correctly on all added protocols
> -----------------------------------------------------------------------------
>
>                 Key: JGRP-1926
>                 URL: https://issues.jboss.org/browse/JGRP-1926
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>             Fix For: 3.6.4
>
>         Attachments: bla.java
>
>
> The attached program doesn't work because `RAFT.init()` tries to find `GMS` on the main stack, but `GMS` hasn't yet been created. Same issue with adding an `AddressGenerator` in `RAFT.init()`.
> Is `start()` called at all on protocols added by `FORK` on top of the main channel ? Is `init()` called at the right time ?
> The attached bla program reproduces the issue (in jgroups-raft).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)