[jboss-jira] [JBoss JIRA] (LOGMGR-126) Log rotation fails on Windows if target already exists

[Panagiotis Sotiropoulos (JIRA)]

Panagiotis Sotiropoulos created LOGMGR-126:
----------------------------------------------

             Summary: Log rotation fails on Windows if target already exists
                 Key: LOGMGR-126
                 URL: https://issues.jboss.org/browse/LOGMGR-126
             Project: JBoss Log Manager
          Issue Type: Bug
            Reporter: Panagiotis Sotiropoulos
            Assignee: James Perkins
             Fix For: 2.0.4.Final, 2.1.0.Beta1


PeriodicRotatingFileHandler (and others) use File.renameTo() to rename the file. That method is documented as having many implementation-defined aspects, see http://docs.oracle.com/javase/7/docs/api/java/io/File.html#renameTo%28java.io.File%29

One that can be a problem is that on Windows, it will fail if the target file already exists. If you use a ".dd" suffix, this will occur when it rolls over to a new month. It has rarely been a problem, since most people use the year month and day so they are unique. Files.move() can replace existing files, so may be better, and some of the costs of that are likely not to be a problem with how it is using here.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)